On 6/2/20 6:26 AM, Kevin Wolf wrote: > I think I prefer the explicit Dict[str, Any] because it doesn't end up > duplicating the default value, but I just wanted to mention that this > option exists, too. Oh, I see what's going on here now! Thanks, that's very helpful! In this case, for now, I think I like your first solution, too. Someday in the future, I want to look into strictly typed generated SDK objects where mypy *does* know the types of every field in a QMP command object. That's not today, and it's probably not soon, (and it might be never,) but until then, explicitly hinting the kwargs to be Dict[str, Any] is reasonable enough. Thank you so much! --js
- [PATCH RFC 32/32] python/qemu/lib: Add mypy type a... John Snow
- [PATCH RFC 25/32] python//machine.py: Handle None ... John Snow
- [PATCH RFC 27/32] python//machine.py: Add _qmp acc... John Snow
- [PATCH RFC 29/32] python//qtest.py: Check before a... John Snow
- Re: [PATCH RFC 29/32] python//qtest.py: Check... Philippe Mathieu-Daudé
- Re: [PATCH RFC 29/32] python//qtest.py: Check... Philippe Mathieu-Daudé
- [PATCH RFC 26/32] python//machine.py: use qmp.comm... John Snow
- Re: [PATCH RFC 26/32] python//machine.py: use... John Snow
- Re: [PATCH RFC 26/32] python//machine.py:... Kevin Wolf
- Re: [PATCH RFC 26/32] python//machine... Kevin Wolf
- Re: [PATCH RFC 26/32] python//mac... John Snow
- [PATCH RFC 24/32] python//machine.py: Don't modify... John Snow
- [PATCH RFC 28/32] python//machine.py: fix _popen a... John Snow
- [PATCH RFC 30/32] python/qemu/lib: make 'args' sty... John Snow
- [PATCH RFC 19/32] python//qmp.py: add QMPProtocolE... John Snow
- Re: [PATCH RFC 19/32] python//qmp.py: add QMP... Philippe Mathieu-Daudé
- [PATCH RFC 13/32] python/qemu/lib: Adjust tracebac... John Snow
- Re: [PATCH RFC 13/32] python/qemu/lib: Adjust... Philippe Mathieu-Daudé
- Re: [PATCH RFC 13/32] python/qemu/lib: Adjust... Philippe Mathieu-Daudé
- Re: [PATCH RFC 00/32] python/qemu: refactor as ins... Philippe Mathieu-Daudé
