On 1/13/21 8:06 AM, Max Reitz wrote: > @busy is false when the job is paused, which happens all the time > because that is how jobs yield (e.g. for mirror at least since commit > 565ac01f8d3). > > Back when 129 was added (2015), perhaps there was no better way of > checking whether the job was still actually running. Now we have the > @status field (as of 58b295ba52c, i.e. 2018), which can give us exactly > that information. > > Signed-off-by: Max Reitz <[email protected]> > --- > tests/qemu-iotests/129 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <[email protected]> > > diff --git a/tests/qemu-iotests/129 b/tests/qemu-iotests/129 > index 2fc65ada6a..dd23bb2e5a 100755 > --- a/tests/qemu-iotests/129 > +++ b/tests/qemu-iotests/129 > @@ -69,7 +69,7 @@ class TestStopWithBlockJob(iotests.QMPTestCase): > result = self.vm.qmp("stop") > self.assert_qmp(result, 'return', {}) > result = self.vm.qmp("query-block-jobs") > - self.assert_qmp(result, 'return[0]/busy', True) > + self.assert_qmp(result, 'return[0]/status', 'running') > self.assert_qmp(result, 'return[0]/ready', False) > > def test_drive_mirror(self): > -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
