On 1/20/21 10:15 AM, Gerd Hoffmann wrote: > On Wed, Jan 20, 2021 at 04:35:20PM +0100, Philippe Mathieu-Daudé wrote: >> While these requests are invalid, they are not breaking any laws :) >> Rename 'illegal request' as 'invalid request'. > > Given the scsi spec calls this "illegal request" I think it makes sense > to *not* change this and stay consistent with the spec for better > grep-ability. Note the variables are already renamed, I expect the > comments have been left as-is intentionally ...
Consistency with the spec and grep-ability takes precedence over any pet peeves of mine. I'm fine if we disregard this patch. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
