On Fri, Apr 16, 2021 at 11:09:00AM +0300, Vladimir Sementsov-Ogievskiy wrote: > monitor_cur() is used by socket_get_fd, but it doesn't work in > connection thread. Let's monitor directly to cover this thing. We are > going to unify connection establishing path in nbd_open and reconnect, > so we should support fd-passing.
Grammar suggestion: Let's pass in the monitor directly to work around this. This gets us closer to unifing the path for establishing a connection in nbd_open and reconnect, by supporting fd-passing. But given Dan's review on 21/33, I suspect you won't be using this patch in this form after all (instead, the caller of nbd_client_connection_new will use the new monitor_resolve_fd or whatever we call that, so that nbd_client_connection_new remains oblivious to the monitor). -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
