On Mon, Jul 12, 2021 at 10:18:30AM +0200, Kevin Wolf wrote: > > Is it feasible that someone would want two separate lists: one for > > qemu (which runs run efficiently) and another for tools (which ones do > > we support at all)? As written, your patch offers no chance to > > distinguish between the two. > > Possibly. However, supporting a second list would require a much larger > code change than this patch, so I'd say this is a problem we should only > solve when someone actually has it.
Indeed. > > > Also, is now a good time to join the bandwagon on picking a more > > descriptive name (such as 'allow-list') for this terminology? > > I don't have an opinion on the time, but I do have an opinion on using a > separate email thread for it. :-) Agreed with that sentiment. > > Initially I tried to find a way not to use "whitelist" in the new option > name, but that only made things inconsistent and confusing, and renaming > the existing options is definitely out of scope for this patch. Also agreed. Therefore, reviewing this patch in isolation (even if we eventually do followups for the issues I pointed out) is fine, and you now have: Reviewed-by: Eric Blake <[email protected]> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
