On Thu, Aug 05, 2021 at 04:36:03PM +0200, Max Reitz wrote: > gluster's block-status implementation is basically a copy of that in > block/file-posix.c, there is only one thing missing, and that is > aligning trailing data extents to the request alignment (as added by > commit 9c3db310ff0). > > Note that 9c3db310ff0 mentions that "there seems to be no other block > driver that sets request_alignment and [...]", but while block/gluster.c > does indeed not set request_alignment, block/io.c's > bdrv_refresh_limits() will still default to an alignment of 512 because > block/gluster.c does not provide a byte-aligned read function. > Therefore, unaligned tails can conceivably occur, and so we should apply > the change from 9c3db310ff0 to gluster's block-status implementation. > > Reported-by: Vladimir Sementsov-Ogievskiy <[email protected]> > Signed-off-by: Max Reitz <[email protected]> > --- > block/gluster.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+)
Probably not a show-stopper for 6.1, so I'm fine if it sits until 6.2. Reviewed-by: Eric Blake <[email protected]> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
