On Fri, May 13, 2022, 4:26 AM Paolo Bonzini <[email protected]> wrote:
> On 5/13/22 02:06, John Snow wrote: > > diff --git a/tests/requirements.txt b/tests/requirements.txt > > index a21b59b4439..0ba561b6bdf 100644 > > --- a/tests/requirements.txt > > +++ b/tests/requirements.txt > > @@ -1,5 +1,6 @@ > > # Add Python module requirements, one per line, to be installed > > # in the tests/venv Python virtual environment. For more info, > > # refer to: https://pip.pypa.io/en/stable/user_guide/#id1 > > +# Note that qemu.git/python/ is always implicitly installed. > > avocado-framework==88.1 > > pycdlib==1.11.0 > > Any reason not to put ./python here? But anyway, > > Reviewed-by: Paolo Bonzini <[email protected]> > > Paolo > The path didn't work under all circumstances - I got some bad path errors for some permutations of CWD/build-type. And I was not able to combine -e (for qemu) and -r (for this file) in a single command, so I kept the qemu install separate/special. Not ideal, I do admit. (I wanted -e for the in-tree install to not create a potential future landmine for someone changing python code and then getting confused as to why nothing changed when running e.g. iotests.)
