On Mon, Nov 06, 2023 at 07:15:12PM +0000, Alex Bennée wrote: > - case CHR_EVENT_CLOSED: > - /* defer close until later to avoid circular close */ > - vhost_user_async_close(dev, &gpio->chardev, &gpio->vhost_dev, > - vu_gpio_disconnect, vu_gpio_event);
I don't remember what is the circular close but I'd be much calmer if this refactoring also didn't change behaviour. Or if it does, please document why it's safe in the commit log. -- MST