On Thu, Jan 25, 2024 at 06:25:12PM +0200, Avihai Horon wrote:
> The commit in the fixes line mistakenly modified the channels and
> transport compatibility check logic so it now checks multi-channel
> support only for socket transport type.
>
> Thus, running multifd migration using a transport other than socket that
> is incompatible with multi-channels (such as "exec") would lead to a
> segmentation fault instead of an error message.
> For example:
> (qemu) migrate_set_capability multifd on
> (qemu) migrate -d "exec:cat > /tmp/vm_state"
> Segmentation fault (core dumped)
>
> Fix it by checking multi-channel compatibility for all transport types.
>
> Fixes: d95533e1cdcc ("migration: modify
> migration_channels_and_uri_compatible() for new QAPI syntax")
> Signed-off-by: Avihai Horon <avih...@nvidia.com>
Reviewed-by: Peter Xu <pet...@redhat.com>
--
Peter Xu
