Re: [PATCH v3 07/11] gdbstub: Introduce gdb_handle_query_supported_user()

[Richard Henderson]

On 2/16/24 03:05, Ilya Leoshkevich wrote:

The upcoming follow-fork-mode child support requires advertising the
fork-events feature, which is user-specific. Introduce a user-specific
hook for this.

Signed-off-by: Ilya Leoshkevich <i...@linux.ibm.com>
---
  gdbstub/gdbstub.c   | 12 +++++++++---
  gdbstub/internals.h |  1 +
  gdbstub/user.c      |  4 ++++
  3 files changed, 14 insertions(+), 3 deletions(-)

diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c
index 7e73e916bdc..43d79dfdd59 100644
--- a/gdbstub/gdbstub.c
+++ b/gdbstub/gdbstub.c
@@ -1599,6 +1599,7 @@ static void handle_query_thread_extra(GArray *params, 
void *user_ctx)

static void handle_query_supported(GArray *params, void *user_ctx)

  {
+    const char *gdb_supported;
      CPUClass *cc;

g_string_printf(gdbserver_state.str_buf, "PacketSize=%x", MAX_PACKET_LENGTH);

@@ -1622,9 +1623,14 @@ static void handle_query_supported(GArray *params, void 
*user_ctx)
      g_string_append(gdbserver_state.str_buf, ";qXfer:exec-file:read+");
  #endif

- if (params->len &&

-        strstr(get_param(params, 0)->data, "multiprocess+")) {
-        gdbserver_state.multiprocess = true;
+    if (params->len) {
+        gdb_supported = get_param(params, 0)->data;

Declare here.

Reviewed-by: Richard Henderson <richard.hender...@linaro.org>

r~