On Fri, Feb 16, 2024 at 03:58:39PM +0100, Markus Armbruster wrote: > The parser recognizes only the first "Features:" line. Any subsequent > ones are treated as ordinary text, as visible in test case > doc-duplicate-features. Recognize "Features:" lines anywhere. A > second one is an error. > > A 'Features:' line without any features is useless, but not an error. > Make it an error. This makes detecting a second "Features:" line > easier. > > qapi/run-state.json actually has an instance of this since commit > fe17522d854 (qapi: Remove deprecated 'singlestep' member of > StatusInfo). Clean it up. > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > qapi/run-state.json | 2 -- > scripts/qapi/parser.py | 8 ++++++- > tests/qapi-schema/doc-duplicate-features.err | 1 + > tests/qapi-schema/doc-duplicate-features.out | 22 -------------------- > tests/qapi-schema/doc-empty-features.err | 1 + > tests/qapi-schema/doc-empty-features.out | 17 --------------- > 6 files changed, 9 insertions(+), 42 deletions(-)
Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
