From: Akihiko Odaki <akihiko.od...@daynix.com> qemu_smbios_type8_opts did not have the list terminator and that resulted in out-of-bound memory access. It also needs to have an element for the type option.
Cc: qemu-sta...@nongnu.org Fixes: fd8caa253c56 ("hw/smbios: support for type 8 (port connector)") Signed-off-by: Akihiko Odaki <akihiko.od...@daynix.com> Reviewed-by: Michael Tokarev <m...@tls.msk.ru> Reviewed-by: Ani Sinha <anisi...@redhat.com> Reviewed-by: Michael S. Tsirkin <m...@redhat.com> Signed-off-by: Michael Tokarev <m...@tls.msk.ru> (cherry picked from commit 196578c9d051d19c23e6c13e97b791a41b318315) diff --git a/hw/smbios/smbios.c b/hw/smbios/smbios.c index 7a58d50d80..9f4d007d96 100644 --- a/hw/smbios/smbios.c +++ b/hw/smbios/smbios.c @@ -345,6 +345,11 @@ static const QemuOptDesc qemu_smbios_type4_opts[] = { }; static const QemuOptDesc qemu_smbios_type8_opts[] = { + { + .name = "type", + .type = QEMU_OPT_NUMBER, + .help = "SMBIOS element type", + }, { .name = "internal_reference", .type = QEMU_OPT_STRING, @@ -365,6 +370,7 @@ static const QemuOptDesc qemu_smbios_type8_opts[] = { .type = QEMU_OPT_NUMBER, .help = "port type", }, + { /* end of list */ } }; static const QemuOptDesc qemu_smbios_type11_opts[] = { -- 2.39.2