On Tue, 20 Feb 2024 at 18:46, Philippe Mathieu-Daudé <phi...@linaro.org> wrote: > > On 20/2/24 18:44, Peter Maydell wrote: > > We don't support 32-bit Windows any more, so we don't need to defend it > > with this CI job. > > > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > > --- > > .gitlab-ci.d/container-cross.yml | 5 - > > .gitlab-ci.d/crossbuilds.yml | 14 --- > > .../dockerfiles/fedora-win32-cross.docker | 111 ------------------ > > tests/lcitool/refresh | 5 - > > 4 files changed, 135 deletions(-) > > delete mode 100644 tests/docker/dockerfiles/fedora-win32-cross.docker > > > > diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml > > index d19d98cde05..987ba9694ba 100644 > > --- a/.gitlab-ci.d/crossbuilds.yml > > +++ b/.gitlab-ci.d/crossbuilds.yml > > @@ -159,20 +159,6 @@ cross-mips64el-kvm-only: > > IMAGE: debian-mips64el-cross > > EXTRA_CONFIGURE_OPTS: --disable-tcg --target-list=mips64el-softmmu > > > > -cross-win32-system: > > - extends: .cross_system_build_job > > - needs: > > - job: win32-fedora-cross-container > > - variables: > > - IMAGE: fedora-win32-cross > > - EXTRA_CONFIGURE_OPTS: --enable-fdt=internal > > - CROSS_SKIP_TARGETS: alpha-softmmu avr-softmmu hppa-softmmu m68k-softmmu > > - microblazeel-softmmu mips64el-softmmu nios2-softmmu > > Thomas, is it possible to add mips64el-softmmu to the cross-win64-system > job or is it already at the timeout limit?
This is a skip, i.e. exclude, list, not an include list. So dropping this job is not removing mips64el-softmmu from coverage. The Windows build coverage we lose will be the targets we are skipping in the cross-win64-system job and weren't skipping here: or1k-softmmu rx-softmmu sh4eb-softmmu sparc64-softmmu tricore-softmmu xtensaeb-softmmu which then fall into the same bucket as alpha-softmmu avr-softmmu hppa-softmmu m68k-softmmu microblazeel-softmmu nios2-softmmu which are already not built in either cross-win*-system job. Is there a reason why we aren't covering those in Windows builds? thanks -- PMM
