On 14/5/24 13:02, Markus Armbruster wrote:
Markus Armbruster <arm...@redhat.com> writes:

Some, but not all error messages are of the form

     Guest agent command failed, error was '<actual error message>'

For instance, command guest-exec can fail with an error message like

     Guest agent command failed, error was 'Failed to execute child process 
“/bin/invalid-cmd42” (No such file or directory)'

Shorten this to just just the actual error message.  The guest-exec
example becomes

     Failed to execute child process “/bin/invalid-cmd42” (No such file or 
directory)

Signed-off-by: Markus Armbruster <arm...@redhat.com>

[...]

To be squashed into the patch:

diff --git a/qga/commands.c b/qga/commands.c
index 27b16313ea..5a5fad31f8 100644
--- a/qga/commands.c
+++ b/qga/commands.c
@@ -15,7 +15,6 @@
  #include "guest-agent-core.h"
  #include "qga-qapi-commands.h"
  #include "qapi/error.h"
-#include "qapi/qmp/qerror.h"
  #include "qemu/base64.h"
  #include "qemu/cutils.h"
  #include "commands-common.h"


Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>


Reply via email to