On 26 March 2012 18:28, Andreas Färber <afaer...@suse.de> wrote: > +static void arm_cpu_reset(CPUState *c) > +{ > + ARMCPU *cpu = ARM_CPU(c); > + ARMCPUClass *class = ARM_CPU_GET_CLASS(cpu); > + > + class->parent_reset(c);
I thought we were avoiding 'class' in favour of 'klass'? > +static const TypeInfo arm_cpu_type_info = { > + .name = TYPE_ARM_CPU, > + .parent = TYPE_CPU, > + .instance_size = sizeof(ARMCPU), > + .abstract = false, /* TODO Reconsider once cp15 reworked. */ As it happens I'm planning to create the per-implementation subclasses first and do the cp15 rework second. -- PMM