Hi Phil,
On 6/27/24 3:02 AM, Philippe Mathieu-Daudé wrote:
On 27/6/24 06:13, Gustavo Romero wrote:
Move GdbCmdParseEntry and its associated types into a separate header
file to allow the use of GdbCmdParseEntry and other gdbstub command
functions outside of gdbstub.c.
Since GdbCmdParseEntry and get_param are now public, kdoc
GdbCmdParseEntry and rename get_param to gdb_get_cmd_param.
This commit also makes gdb_put_packet public since is used in gdbstub
command handling.
Signed-off-by: Gustavo Romero <gustavo.rom...@linaro.org>
Reviewed-by: Alex Bennée <alex.ben...@linaro.org>
---
gdbstub/gdbstub.c | 134 ++++++++++++++-----------------------
gdbstub/internals.h | 22 ------
gdbstub/syscalls.c | 7 +-
gdbstub/system.c | 7 +-
gdbstub/user-target.c | 25 +++----
gdbstub/user.c | 7 +-
include/gdbstub/commands.h | 74 ++++++++++++++++++++
7 files changed, 148 insertions(+), 128 deletions(-)
create mode 100644 include/gdbstub/commands.h
+#define get_cmd_parsers(p) (&g_array_index(p, GdbCmdParseEntry, 0))
Dead code AFAICT.
Yes, that's a leftover. Removed in v6. Thanks.
Cheers,
Gustavo
