On Mon May 27, 2024 at 9:12 AM AEST, BALATON Zoltan wrote:
> The ptem variable in ppc6xx_tlb_pte_check() is used only once,
> simplify by removing it as the value is already clear itself without
> adding a local name for it.
>
> Signed-off-by: BALATON Zoltan <bala...@eik.bme.hu>
Reviewed-by: Nicholas Piggin <npig...@gmail.com>
> ---
> target/ppc/mmu_common.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/target/ppc/mmu_common.c b/target/ppc/mmu_common.c
> index 2618cdec6a..371ec24485 100644
> --- a/target/ppc/mmu_common.c
> +++ b/target/ppc/mmu_common.c
> @@ -98,7 +98,6 @@ static int ppc6xx_tlb_pte_check(mmu_ctx_t *ctx,
> target_ulong pte0,
> target_ulong pte1, int h,
> MMUAccessType access_type)
> {
> - target_ulong ptem;
> int ret, pteh, ptev, pp;
>
> ret = -1;
> @@ -107,9 +106,8 @@ static int ppc6xx_tlb_pte_check(mmu_ctx_t *ctx,
> target_ulong pte0,
> pteh = (pte0 >> 6) & 1;
> if (ptev && h == pteh) {
> /* Check vsid & api */
> - ptem = pte0 & PTE_PTEM_MASK;
> pp = pte1 & 0x00000003;
> - if (ptem == ctx->ptem) {
> + if ((pte0 & PTE_PTEM_MASK) == ctx->ptem) {
> if (ctx->raddr != (hwaddr)-1ULL) {
> /* all matches should have equal RPN, WIMG & PP */
> if ((ctx->raddr & PTE_CHECK_MASK) != (pte1 &
> PTE_CHECK_MASK)) {
