On Mon May 27, 2024 at 9:12 AM AEST, BALATON Zoltan wrote:
> The ptev variable in ppc6xx_tlb_pte_check() is used only once and just
> obfuscates an otherwise clear value. Get rid of it.
>
> Signed-off-by: BALATON Zoltan <bala...@eik.bme.hu>
Reviewed-by: Nicholas Piggin <npig...@gmail.com>
> ---
> target/ppc/mmu_common.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/target/ppc/mmu_common.c b/target/ppc/mmu_common.c
> index 371ec24485..16578f7fa5 100644
> --- a/target/ppc/mmu_common.c
> +++ b/target/ppc/mmu_common.c
> @@ -98,13 +98,12 @@ static int ppc6xx_tlb_pte_check(mmu_ctx_t *ctx,
> target_ulong pte0,
> target_ulong pte1, int h,
> MMUAccessType access_type)
> {
> - int ret, pteh, ptev, pp;
> + int ret, pteh, pp;
>
> ret = -1;
> /* Check validity and table match */
> - ptev = pte_is_valid(pte0);
> pteh = (pte0 >> 6) & 1;
> - if (ptev && h == pteh) {
> + if (pte_is_valid(pte0) && h == pteh) {
> /* Check vsid & api */
> pp = pte1 & 0x00000003;
> if ((pte0 & PTE_PTEM_MASK) == ctx->ptem) {
