On 2024/8/2 13:38, Richard Henderson wrote:
On 8/2/24 13:16, LIU Zhiwei wrote:
@@ -47,7 +47,12 @@ static bool trans_fld(DisasContext *ctx, arg_fld *a)
REQUIRE_FPU;
REQUIRE_EXT(ctx, RVD);
- if (ctx->cfg_ptr->ext_zama16b && (ctx->cur_insn_len != 2)) {
+ /*
+ * Zama16b applies to loads and stores of no more than MXLEN
bits defined
+ * in the F, D, and Q extensions. Otherwise, it falls through to
default
+ * MO_ATOM_IFALIGN.
+ */
+ if ((ctx->xl >= MXL_RV64) && (ctx->cfg_ptr->ext_zama16b)) {
I think you meant to add the mxlen check in the next patch,
because you modify this line again.
Oh, I didn't notice it. I once split the whole patch into two patches.
But obviously I did only a half.
Thanks,
Zhiwei
r~
