Michael Tokarev <m...@tls.msk.ru> writes: > 28.08.2024 17:56, Fabiano Rosas wrote: >> The send_cleanup() hook should free the p->iov that was allocated at >> send_setup(). This was missed because the UADK code is conditional on >> the presence of the accelerator, so it's not tested by default. >> >> Fixes: 819dd20636 ("migration/multifd: Add UADK initialization") >> Reported-by: Peter Xu <pet...@redhat.com> >> Signed-off-by: Fabiano Rosas <faro...@suse.de> >> --- >> migration/multifd-uadk.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/migration/multifd-uadk.c b/migration/multifd-uadk.c >> index 89f6a72f0e..6e6a290ae9 100644 >> --- a/migration/multifd-uadk.c >> +++ b/migration/multifd-uadk.c >> @@ -132,6 +132,8 @@ static void multifd_uadk_send_cleanup(MultiFDSendParams >> *p, Error **errp) >> >> multifd_uadk_uninit_sess(wd); >> p->compress_data = NULL; >> + g_free(p->iov); >> + p->iov = NULL; >> } > > This sounds like something for stable-9.1.x, is it not?
Right, it is. > > Thanks, > > /mjt