Re: [PATCH v2 01/21] accel/tcg: Assert noreturn from write-only page for atomics

[Helge Deller]

On 10/5/24 22:05, Richard Henderson wrote:

There should be no "just in case"; the page is already
in the tlb, and known to be not readable.

Signed-off-by: Richard Henderson <richard.hender...@linaro.org>

Reviewed-by: Helge Deller <del...@gmx.de>

---
  accel/tcg/cputlb.c | 5 ++---
  1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c
index 117b516739..fd6459b695 100644
--- a/accel/tcg/cputlb.c
+++ b/accel/tcg/cputlb.c
@@ -1852,10 +1852,9 @@ static void *atomic_mmu_lookup(CPUState *cpu, vaddr 
addr, MemOpIdx oi,
          /*
           * Since we don't support reads and writes to different
           * addresses, and we do have the proper page loaded for
-         * write, this shouldn't ever return.  But just in case,
-         * handle via stop-the-world.
+         * write, this shouldn't ever return.
           */
-        goto stop_the_world;
+        g_assert_not_reached();
      }
      /* Collect tlb flags for read. */
      tlb_addr |= tlbe->addr_read;