On Mon, 2024-10-21 at 14:39 +0200, Cédric Le Goater wrote: > On 10/18/24 07:31, Jamin Lin wrote: > > Currently, these test cases used the hardcode offset 0x1400000 (0x14000 * > > 256) > > which was beyond the 16MB flash size for flash page read/write command > > testing. > > However, the default fmc flash model of ast1030-a1 EVB is "w25q80bl" whose > > size > > is 1MB. To test all flash models, introduces a new page_addr member in > > TestData > > structure, so users can set the offset for flash parge read/write command > > testing. > > The commit title and description are confusing. By "all flash" models, > do you mean "all Aspeed SoC" models ?
I think it only relates to the SoCs insofar as the AST1030 embeds some flash in the SoC? Otherwise it's dependent on the flash model associated with the board? > > Since the change is introducing a 'page_addr' data field. I think > this should be the title. I agree that including something about page_addr in the title would be an improvement. Andrew
