On 24/10/2024 03:42, Philippe Mathieu-Daudé wrote:
On 23/10/24 05:58, Mark Cave-Ayland wrote:
Change the start of the next.mmio memory region so that it follows on directly
after the next.dma memory region, adjusting the address offsets in
next_mmio_read() and next_mmio_write() accordingly.
Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk>
---
hw/m68k/next-cube.c | 28 ++++++++++++++--------------
1 file changed, 14 insertions(+), 14 deletions(-)
@@ -897,7 +897,7 @@ static void next_pc_realize(DeviceState *dev, Error **errp)
qdev_init_gpio_in(dev, next_irq, NEXT_NUM_IRQS);
memory_region_init_io(&s->mmiomem, OBJECT(s), &next_mmio_ops, s,
- "next.mmio", 0xd0000);
+ "next.mmio", 0x9000);
Please mention 0xd0000 was incorrect, otherwise:
Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>
This one is a little more fuzzy, since I'm not even sure that the new value 0x9000 is
correct (there isn't much in the way of documentation to support this) - effectively
the purpose of truncating this memory region is to remove the overlap with another so
that MMIO accesses are consistently directed to the same handler.
I'll have a think about how I can re-word this better for a v2.
ATB,
Mark.
