On Mon, Nov 11, 2024 at 12:04 AM Daniel Henrique Barboza <dbarb...@ventanamicro.com> wrote: > > > > On 11/10/24 10:54 AM, Philippe Mathieu-Daudé wrote: > > On 9/11/24 22:46, Anton Blanchard wrote: > >> Hi Philippe, > >> > >> On Sun, Nov 10, 2024 at 5:21 AM Philippe Mathieu-Daudé > >> <phi...@linaro.org> wrote: > >>> Generally speaking (I'm not objecting to this patch as is), for > >>> DEFINE_VENDOR_CPU() it would be nice to have reference to some > >>> documentation -- at least to review whether the cpu features > >>> announced make sense or not --. > >>> > >>> For this particular IP I'm not finding anything on the company > >>> website...: > >>> https://docs.tenstorrent.com/search.html?q=Ascalon > >> > >> This has some more details, including a 1 page PDF. Should I add the URL to > >> the commit message? > >> > >> https://tenstorrent.com/ip/tt-ascalon > > > > This seems a sales presentation, not very useful technically, so better > > no IMHO. > > > The link has a 'Download One-Pager' button where you can download a PDF. > > The PDF is a bit more technical and it mentions that the CPU is RVA23 > compliant, > which give us an idea of the extensions that the CPU provides. I think this is > enough. > > Alistair, what do you think?
I think a link is better then no link, even if it is aimed at sales Alistair
