On Wed, Nov 13, 2024 at 04:46:14PM -0300, Fabiano Rosas wrote: > We current have a bunch of non-test functions in migration-test.c and > some others in migration-helpers.c. In order to split migration-test.c > into separate test binaries, these helpers need to go somewhere > else. > > To avoid making migration-helpers even larger, move all QMP-related > functions into a new migration-qmp.c file and put it under the > qtest/migration/ directory. > > The new file holds everything that has as its main responsibility to > call into QMP. > > Signed-off-by: Fabiano Rosas <faro...@suse.de> > --- > tests/qtest/meson.build | 1 + > tests/qtest/migration-helpers.c | 250 +------------ > tests/qtest/migration-helpers.h | 18 +- > tests/qtest/migration-test.c | 237 +------------ > tests/qtest/migration/migration-qmp.c | 485 ++++++++++++++++++++++++++ > tests/qtest/migration/migration-qmp.h | 44 +++ > tests/qtest/virtio-net-failover.c | 1 + > 7 files changed, 540 insertions(+), 496 deletions(-) > create mode 100644 tests/qtest/migration/migration-qmp.c > create mode 100644 tests/qtest/migration/migration-qmp.h > > diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build > index 16823a9202..ca199b9491 100644 > --- a/tests/qtest/meson.build > +++ b/tests/qtest/meson.build > @@ -333,6 +333,7 @@ tpmemu_files = ['tpm-emu.c', 'tpm-util.c', 'tpm-tests.c'] > migration_files = [files( > 'migration-helpers.c', > 'migration/bootfile.c', > + 'migration/migration-qmp.c', > )]
Not relevant to this patch alone, but ... this looks like a nested list. I assume meson does some auto-flatten things. Reviewed-by: Peter Xu <pet...@redhat.com> -- Peter Xu
