On Thu, Dec 05, 2024 at 10:20:47PM +0100, Paolo Bonzini wrote: > Date: Thu, 5 Dec 2024 22:20:47 +0100 > From: Paolo Bonzini <pbonz...@redhat.com> > Subject: Re: [RFC 11/13] rust/timer/hpet: add basic HPET timer & state > > On Thu, Dec 5, 2024 at 9:23 PM Paolo Bonzini <pbonz...@redhat.com> wrote: > > > + /// Instance id (HPET timer block ID). > > > + hpet_id: BqlCell<usize>, > > > +} > > > + > > Like flags this does not need to be a cell. > > Well, this *should not* need to be a cell (ideally fw_cfg would call a > C function to generate FW_CFG_HPET) but it can't be done yet, so you > can keep it. flags need not be a BqlCell though.
Thank you! I'll look at how to implement C function's workflow. At least, I'll leave a TODO to remind me to cleanup this BqlCell. (Now I did overuse the BqlCell a bit! :-) This is also an opportunity for me to carefully review the correct usage.) Regards, Zhao
