Re: [PATCH 10/37] accel/tcg: Use cpu_ld*_code_mmu in translator.c

[Richard Henderson]

On 3/13/25 10:21, Pierrick Bouvier wrote:

On 3/12/25 20:44, Richard Henderson wrote:

  uint64_t translator_ldq(CPUArchState *env, DisasContextBase *db, vaddr pc)
  {
-    uint64_t raw, tgt;
+    uint64_t val;
-    if (translator_ld(env, db, &raw, pc, sizeof(raw))) {
-        tgt = tswap64(raw);
-    } else {
-        tgt = cpu_ldq_code(env, pc);
-        raw = tswap64(tgt);
-        record_save(db, pc, &raw, sizeof(raw));
+    if (!translator_ld(env, db, &val, pc, sizeof(val))) {
+        MemOpIdx oi = make_memop_idx(MO_UL, db->code_mmuidx);

Should it be MO_UQ?

Yep, thanks.

r~