On 4/22/25 03:59, Jamin Lin wrote:
Hi Cedric,
Subject: Re: [PATCH v4 02/10] hw/arm/aspeed_ast27x0 Introduce vbootrom
memory region
On 4/17/25 05:11, Jamin Lin wrote:
Introduce a new vbootrom memory region. The region is mapped at
address "0x00000000" and has a size of 128KB, identical to the SRAM region
size.
This memory region is intended for loading a vbootrom image file as
part of the boot process.
The vbootrom registered in the SoC's address space using the
ASPEED_DEV_VBOOTROM index.
Introduced a "vbootrom_size" attribute in "AspeedSoCClass" to define
virtual boot ROM size.
Could you please explain why we need a class attribute to size the vbootrom
region ? The rest looks good.
I've reviewed the SRAM design and used it as a reference to create a new class
attribute for setting the size of the vbootrom memory region.
Currently, I don't plan to support different vbootrom images for the AST27x0.
My understanding is that a single vbootrom image should be sufficient to
support all AST27x0 variants.
If you agree, I will remove this class attribute and instead hardcode the
vbootrom size to 128KB.
Looks good to me.
Thanks,
C.
