Re: [PATCH] tests/qtest/ast2700-smc-test: Fix leak

[Cédric Le Goater]

Jamin, could you check please ?


Thanks,

C.


On 5/9/25 19:50, Fabiano Rosas wrote:

ASAN spotted a leak of the memory used to hold the tmp_path:

Direct leak of 35 byte(s) in 1 object(s) allocated from:
     #0 0x55e29aa96da9 in malloc 
../projects/compiler-rt/lib/asan/asan_malloc_linux.cpp:69:3
     #1 0x7fe0cfb26518 in g_malloc ../glib/gmem.c:106
     #2 0x7fe0cfb4146e in g_strconcat ../glib/gstrfuncs.c:629
     #3 0x7fe0cfb0a78f in g_get_tmp_name ../glib/gfileutils.c:1742
     #4 0x7fe0cfb0b00b in g_file_open_tmp ../glib/gfileutils.c:1802
     #5 0x55e29ab53961 in test_ast2700_evb 
../tests/qtest/ast2700-smc-test.c:20:10
     #6 0x55e29ab53803 in main ../tests/qtest/ast2700-smc-test.c:65:5
     #7 0x7fe0cf7bd24c in __libc_start_main ../csu/libc-start.c:308
     #8 0x55e29a9f7759 in _start ../sysdeps/x86_64/start.S:120

Signed-off-by: Fabiano Rosas <faro...@suse.de>
---
  tests/qtest/ast2700-smc-test.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/tests/qtest/ast2700-smc-test.c b/tests/qtest/ast2700-smc-test.c
index d1c4856307..62d538d8a3 100644
--- a/tests/qtest/ast2700-smc-test.c
+++ b/tests/qtest/ast2700-smc-test.c
@@ -67,5 +67,6 @@ int main(int argc, char **argv)

qtest_quit(ast2700_evb_data.s);

      unlink(ast2700_evb_data.tmp_path);
+    g_free(ast2700_evb_data.tmp_path);
      return ret;
  }