On 5/14/25 22:25, Philippe Mathieu-Daudé wrote:
Hi Michael,
Minor comments inline.
On 14/5/25 09:39, Michael Clark wrote:
[snipped]
+
+static void x86_print_row(size_t count, x86_table_col *cols)
+{
+ printf("|");
+ for (size_t i = 0; i < count; i++) {
+ printf(" %-*s |", cols[i].width, cols[i].data);
+ g_free(cols[i].data);
+ }
+ printf("\n");
Shouldn't we use info->fprintf_func() in disas/ ?
this could be dead code which I could possibly remove from the patch.
the upstream has a metadata table tool that prints out metadata. an
alternative approach is to add the metadata table tools as utilities.
+}
const
the const changes all seem to make sense.
