Re: [PATCH v3 6/9] scripts/checkpatch: expand pattern for matching makefiles

[Cédric Le Goater]

On 5/15/25 15:59, Daniel P. Berrangé wrote:

The current regex matches Makefile & Makefile.objs, but the latter is
no longer used, and we're missing coverage of Makefile.include and
Makefile.target. Expand the pattern to match any suffix.

Signed-off-by: Daniel P. Berrangé <berra...@redhat.com>
---
  scripts/checkpatch.pl | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 4a18daa384..00d7d72e53 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1453,7 +1453,7 @@ sub process_start_of_file {
                my $permhere = $fileinfo->{linestart} . "FILE: " .
                        $fileinfo->{filenew} . "\n";
                if ($fileinfo->{filenew} =~
-                   /(\bMakefile(?:\.objs)?|\.(c|cc|cpp|h|mak|s|S))$/) {
+                   /(\bMakefile.*|\.(c|cc|cpp|h|mak|s|S))$/) {
                        ERROR("do not set execute permissions for source " .
                              "files\n" . $permhere);
                }

Reviewed-by: Cédric Le Goater <c...@redhat.com>

Thanks,

C.