On Thu, 15 May 2025 at 14:59, Daniel P. Berrangé <berra...@redhat.com> wrote: > > Various checks in the code were under-indented relative to other > surrounding code.
Isn't the problem here not that they're under-indented, but that they don't follow the "indent with hard coded tab characters" style that the rest of the script does? Looking at the patch on patchew it looks like these changes do make the code use hardcoded tabs, but I think it would be worth mentioning that in the commit message. (I assumed from the wording -- and also because my mail client was being misleading -- that these changes were adding 8-space indent.) Otherwise Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM
