On 5/19/25 16:19, Julian Ganz wrote:
We recently introduced API for registering callbacks for trap related
events as well as the corresponding hook functions. Due to differences
between architectures, the latter need to be called from target specific
code.
This change places hooks for Alpha targets.
Signed-off-by: Julian Ganz <neither@nut.email>
---
target/alpha/helper.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/target/alpha/helper.c b/target/alpha/helper.c
index 096eac3445..a9af52a928 100644
--- a/target/alpha/helper.c
+++ b/target/alpha/helper.c
@@ -27,6 +27,7 @@
#include "exec/helper-proto.h"
#include "qemu/qemu-print.h"
#include "system/memory.h"
+#include "qemu/plugin.h"
#define CONVERT_BIT(X, SRC, DST) \
@@ -328,6 +329,7 @@ void alpha_cpu_do_interrupt(CPUState *cs)
{
CPUAlphaState *env = cpu_env(cs);
int i = cs->exception_index;
+ uint64_t last_pc = env->pc;
if (qemu_loglevel_mask(CPU_LOG_INT)) {
static int count;
@@ -431,6 +433,17 @@ void alpha_cpu_do_interrupt(CPUState *cs)
/* Switch to PALmode. */
env->flags |= ENV_FLAG_PAL_MODE;
+
+ switch (i) {
+ case EXCP_SMP_INTERRUPT:
+ case EXCP_CLK_INTERRUPT:
+ case EXCP_DEV_INTERRUPT:
+ qemu_plugin_vcpu_interrupt_cb(cs, last_pc);
+ break;
+ default:
+ qemu_plugin_vcpu_exception_cb(cs, last_pc);
+ break;
+ }
Having read the whole series now, I think it would be better to change the
TCGCPUOps.do_interrupt interface.
Instead of having each target call qemu_plugin_*, instead have each do_interrupt return
the discontinuity type, or 0 if the interrupt is blocked so no state change.
Change to cpu_handle_exception would be of the form:
if (qemu_plugin_discon_enabled(cpu)) {
vaddr from = tcg_ops->get_pc(cpu);
unsigned ev = tcg_ops->do_interrupt(cpu);
if (ev) {
qemu_plugin_vcpu_discon_cb(cpu, ev, from);
}
} else {
tcg_ops->do_interrupt(cpu);
}
r~
