On 6/10/25 12:22, Mark Cave-Ayland wrote:
On 10/06/2025 11:12, Cédric Le Goater wrote:
On 6/10/25 11:55, John Levon wrote:
On Tue, Jun 10, 2025 at 11:38:29AM +0200, Cédric Le Goater wrote:
docs/devel/vfio-user.rst | 1522 +++++++++++++++++++++++++++ +++++
I think this file should be split in several smaller files. The
protocol specification part belongs to "System Emulation Management
and Interoperability" section.
I can move it to interop/ sure. Why must it be split up ? It's nearest analogue,
vhost-user.rst, is one file, and I think that's better for a protocol
specification.
We already have a docs/system/devices/vfio-user.rst which needs some
care.
My series adds this file. This is the user docs, including a device
example, so independent of the protocol specification.
ah yes. The QEMU documentation is a bit messy. Not your fault.
Please let me know what care it needs!
sure.
(and functional tests)
Mark is working on them, there are some difficulties...
Which kind ? This is important to have and I will be reluctant to merge
any support without tests. It is OK to merge a dummy device implementation
for the tests since they provide a good example.
C.
I have a bootable test image available for testing basic functionality, however
there are a few issues with the functional test framework: in particular the
test framework doesn't currently allow logging of multiple VM consoles
correctly.
What about test_aarch64_aspeed_ast2700fc.py which boots multiple SoCs ?
I am continuing to work on this in the background, and hope to be able to
provide an integrated functional test soon.
Nice ! That would be great.
Thanks Mark,
C.
