Re: [PATCH v3 61/68] accel/tcg: Clear exit_request once in tcg_cpu_exec()

[Richard Henderson]

On 7/1/25 08:40, Philippe Mathieu-Daudé wrote:

Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org>
---
  accel/tcg/tcg-accel-ops-mttcg.c | 1 -
  accel/tcg/tcg-accel-ops.c       | 3 +++
  2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/accel/tcg/tcg-accel-ops-mttcg.c b/accel/tcg/tcg-accel-ops-mttcg.c
index 8a0295e2410..2fb6ced2572 100644
--- a/accel/tcg/tcg-accel-ops-mttcg.c
+++ b/accel/tcg/tcg-accel-ops-mttcg.c
@@ -130,7 +130,6 @@ void *mttcg_cpu_thread_routine(void *arg)
              }
          }

- qatomic_set_mb(&cpu->exit_request, 0);

          qemu_wait_io_event(cpu);
      } while (!cpu->unplug || cpu_can_run(cpu));

diff --git a/accel/tcg/tcg-accel-ops.c b/accel/tcg/tcg-accel-ops.c

index 83fb2d1362c..9b5caf9c4f5 100644
--- a/accel/tcg/tcg-accel-ops.c
+++ b/accel/tcg/tcg-accel-ops.c
@@ -95,6 +95,9 @@ int tcg_cpu_exec(CPUState *cpu)
      cpu_exec_start(cpu);
      ret = cpu_exec(cpu);
      cpu_exec_end(cpu);
+
+    qatomic_set_mb(&cpu->exit_request, 0);
+
      return ret;
  }

Reviewed-by: Richard Henderson <richard.hender...@linaro.org>

r~