On 7/2/25 12:25, Philippe Mathieu-Daudé wrote:
On 2/7/25 17:19, Richard Henderson wrote:
On 7/1/25 08:40, Philippe Mathieu-Daudé wrote:
Allocate ForceRcuNotifier on the Heap.

Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org>
---
  accel/tcg/tcg-accel-ops-mttcg.c | 30 ++++++++++++++++++++++++------
  1 file changed, 24 insertions(+), 6 deletions(-)

Please document the motivation.

 > [...] the structure is still not accessible from anywhere outside
 > of the function, and has the same lifetime as the function.

We need this to register the MTTCG thread in split_cpu_thread_routine():
https://lore.kernel.org/qemu-devel/20250620172751.94231-12-phi...@linaro.org/

Better to have AccelOpsClass::[un]register_thread_rcu() hooks?

I think this is more complex than it needs to be. I think we don't actually need different implementations between mttcg and rr: we just need to make use of current_cpu.

I'll experiment with this.


r~

Reply via email to