On Wed, 2 Jul 2025 at 13:42, Richard Henderson
<richard.hender...@linaro.org> wrote:
>
> Signed-off-by: Richard Henderson <richard.hender...@linaro.org>
> ---
> target/arm/tcg/helper-sve.h | 32 +++++++++
> target/arm/tcg/sve_helper.c | 8 +++
> target/arm/tcg/translate-sve.c | 126 ++++++++++++++++++++++++---------
> target/arm/tcg/sve.decode | 31 ++++++++
> 4 files changed, 162 insertions(+), 35 deletions(-)
> @@ -4812,23 +4812,25 @@ static bool trans_STR_pri(DisasContext *s, arg_rri *a)
> */
>
> /* The memory mode of the dtype. */
> -static const MemOp dtype_mop[18] = {
> +static const MemOp dtype_mop[19] = {
> MO_UB, MO_UB, MO_UB, MO_UB,
> MO_SL, MO_UW, MO_UW, MO_UW,
> MO_SW, MO_SW, MO_UL, MO_UL,
> MO_SB, MO_SB, MO_SB, MO_UQ,
> - MO_UL, MO_UQ,
> + /* Artificial values used by decode */
This comment and the similar one in dtype_esz should have been
added in the earlier patch that added elements 16 and 17.
> + MO_UL, MO_UQ, MO_128
> };
>
> #define dtype_msz(x) (dtype_mop[x] & MO_SIZE)
>
> /* The vector element size of dtype. */
> -static const uint8_t dtype_esz[18] = {
> +static const uint8_t dtype_esz[19] = {
> 0, 1, 2, 3,
> 3, 1, 2, 3,
> 3, 2, 2, 3,
> 3, 2, 1, 3,
> - 4, 4,
> + /* Artificial values used by decode */
> + 4, 4, 4,
> };
Otherwise
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org>
thanks
-- PMM
