Re: [PATCH 02/10] semihosting/guestfd: compile once for system/user

[Richard Henderson]

On 7/31/25 08:06, Pierrick Bouvier wrote:

diff --git a/semihosting/arm-compat-semi.c b/semihosting/arm-compat-semi.c
index 40dc778529d..33614108094 100644
--- a/semihosting/arm-compat-semi.c
+++ b/semihosting/arm-compat-semi.c
@@ -101,6 +101,13 @@ static int gdb_open_modeflags[12] = {
      GDB_O_RDWR | GDB_O_CREAT | GDB_O_APPEND,
  };

+/*

+ * For ARM semihosting, we have a separate structure for routing
+ * data for the console which is outside the guest fd address space.
+ */
+GuestFD console_in_gf;
+GuestFD console_out_gf;

These can now be static.

Otherwise,
Reviewed-by: Richard Henderson <richard.hender...@linaro.org>


r~