On 7/31/25 6:25 PM, Richard Henderson wrote:
On 7/31/25 08:06, Pierrick Bouvier wrote:
Signed-off-by: Pierrick Bouvier <pierrick.bouv...@linaro.org>
---
   semihosting/arm-compat-semi.c | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/semihosting/arm-compat-semi.c b/semihosting/arm-compat-semi.c
index e3b520631b3..715a22528ab 100644
--- a/semihosting/arm-compat-semi.c
+++ b/semihosting/arm-compat-semi.c
@@ -502,7 +502,7 @@ void do_common_semihosting(CPUState *cs)
case TARGET_SYS_ISERROR:
           GET_ARG(0);
-        common_semi_set_ret(cs, (target_long)arg0 < 0);
+        common_semi_set_ret(cs, (int64_t)arg0 < 0);
           break;
case TARGET_SYS_ISTTY:

Here we have a semantic change.  For 32-bit, we used get_user_u32, so this will 
always
return false.


Right... I'll add the intermediate missing cast based on is_64bit_semihosting(env).

Thanks,
Pierrick


r~


Reply via email to