On Wed, 30 Jul 2025 at 01:49, Richard Henderson <richard.hender...@linaro.org> wrote: > > All real definitions of ELF_HWCAP are now identical, and the stub > definitions are 0. Provide a weak stub as a fallback definition. > > Signed-off-by: Richard Henderson <richard.hender...@linaro.org> > --- > linux-user/elfload.c | 34 ++++++++++------------------------ > 1 file changed, 10 insertions(+), 24 deletions(-)
> +/* > + * Provide fallback definitions that the target may omit. > + */ > +abi_ulong __attribute__((weak)) get_elf_hwcap(CPUState *cs) > +{ > + return 0; > +} We make very little use of the weak attribute elsewhere in the codebase, so I'm not super enthusiastic about adding it, but I guess for linux-user we don't have the portability problems that it can create... Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM