Shiju Jose <shiju.j...@huawei.com> writes: >>-----Original Message----- >>From: Markus Armbruster <arm...@redhat.com> >>Sent: 06 August 2025 08:58 >>To: shiju.jose--- via <qemu-devel@nongnu.org> >>Cc: linux-...@vger.kernel.org; Jonathan Cameron >><jonathan.came...@huawei.com>; fan...@samsung.com; d...@stgolabs.net; >>Shiju Jose <shiju.j...@huawei.com>; Linuxarm <linux...@huawei.com> >>Subject: Re: [PATCH qemu v4 2/7] hw/cxl/events: Updates for rev3.2 general >>media event record >> >>shiju.jose--- via <qemu-devel@nongnu.org> writes: >> >>> From: Shiju Jose <shiju.j...@huawei.com> >>> >>> CXL spec rev3.2 section 8.2.10.2.1.1 Table 8-57, general media event >>> table has updated with following new fields. >>> 1. Advanced Programmable Corrected Memory Error Threshold Event Flags >>> 2. Corrected Memory Error Count at Event 3. Memory Event Sub-Type 4. >>> Support for component ID in the PLDM format. >>> >>> Add updates for the above spec changes in the CXL general media event >>> reporting and QMP command to inject general media event. >>> >>> Signed-off-by: Jonathan Cameron <jonathan.came...@huawei.com> >>> Signed-off-by: Shiju Jose <shiju.j...@huawei.com> >> >>[...] >> >>> diff --git a/qapi/cxl.json b/qapi/cxl.json index >>> c1fe8319c8..e8060d16f7 100644 >>> --- a/qapi/cxl.json >>> +++ b/qapi/cxl.json >>> @@ -82,6 +82,19 @@ >>> # @component-id: Device specific component identifier for the event. >>> # May describe a field replaceable sub-component of the device. >>> # >>> +# @is-comp-id-pldm: Flag represents device specific component identifier >>> +# format is PLDM or not. >> >>Awkward phrasing. Before I can suggest a better one, I have a question. >>The type is uint8, which isn't a flag. What are the possible values? > Thanks Markus for the comments.
You're welcome! > 'is-comp-id-pldm' is flag with possible values 0 and 1. > I will use type bool instead of uint8? Yes, please! [...]
