Hi
On Fri, Aug 8, 2025 at 12:08 PM Markus Armbruster <arm...@redhat.com> wrote:
> qemu_pixman_shareable_free() wraps around either qemu_memfd_free() or
> qemu_win32_map_free(). The former reports trouble as error, with
> error_report(), then succeeds. The latter reports it as warning (we
> pass it &error_warn), then succeeds.
>
> Change the latter to report as error, too.
>
> Cc: Marc-André Lureau <marcandre.lur...@redhat.com>
> Signed-off-by: Markus Armbruster <arm...@redhat.com>
>
lgtm, thanks
Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com>
> ---
> ui/qemu-pixman.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/ui/qemu-pixman.c b/ui/qemu-pixman.c
> index ef4e71da11..e46c6232cf 100644
> --- a/ui/qemu-pixman.c
> +++ b/ui/qemu-pixman.c
> @@ -288,7 +288,10 @@ qemu_pixman_shareable_free(qemu_pixman_shareable
> handle,
> void *ptr, size_t size)
> {
> #ifdef WIN32
> - qemu_win32_map_free(ptr, handle, &error_warn);
> + Error *err = NULL;
> +
> + qemu_win32_map_free(ptr, handle, &err);
> + error_report_err(err);
> #else
> qemu_memfd_free(ptr, size, handle);
> #endif
> --
> 2.49.0
>
>
