Re: [PATCH v6 14/19] hw/i386/pc_piix.c: hardcode pcms->pci_bus to NULL in pc_init_isa()

[Xiaoyao Li]

On 8/22/2025 8:12 PM, Mark Cave-Ayland wrote:

By definition PCI can never be enabled on an isapc machine so hardcode the 
PCIBus argument
of pc_nic_init() to NULL.

Signed-off-by: Mark Cave-Ayland <mark.caveayl...@nutanix.com>
Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>

Reviewed-by: Xiaoyao Li <xiaoyao...@intel.com>

---
  hw/i386/pc_piix.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index e8603b585a..49bd1a41e7 100644
--- a/hw/i386/pc_piix.c
+++ b/hw/i386/pc_piix.c
@@ -519,7 +519,7 @@ static void pc_init_isa(MachineState *machine)
      pc_basic_device_init(pcms, isa_bus, x86ms->gsi, x86ms->rtc,
                           !MACHINE_CLASS(pcmc)->no_floppy, 0x4);

- pc_nic_init(pcmc, isa_bus, pcms->pcibus);

+    pc_nic_init(pcmc, isa_bus, NULL);

ide_drive_get(hd, ARRAY_SIZE(hd));

      for (i = 0; i < MAX_IDE_BUS; i++) {