On Fri, Aug 29, 2025 at 03:50:02PM +0400, Marc-André Lureau wrote: > Hi > > On Fri, Aug 29, 2025 at 12:37 PM Zhao Liu <zhao1....@intel.com> wrote: > > > Hi Marc-Andre, > > > > On Wed, Aug 27, 2025 at 02:41:32PM +0400, marcandre.lur...@redhat.com > > wrote: > > > Date: Wed, 27 Aug 2025 14:41:32 +0400 > > > From: marcandre.lur...@redhat.com > > > Subject: [PATCH 10/22] rust: split "migration" crate > > > > > > From: Marc-André Lureau <marcandre.lur...@redhat.com> > > > > > > Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> > > > --- > > > > ... > > > > > @@ -0,0 +1,51 @@ > > > +/* > > > + * QEMU System Emulator > > > + * > > > + * Copyright (c) 2024 Linaro Ltd. > > > + * > > > + * Authors: Manos Pitsidianakis <manos.pitsidiana...@linaro.org> > > > + * > > > + * Permission is hereby granted, free of charge, to any person > > obtaining a copy > > > + * of this software and associated documentation files (the > > "Software"), to deal > > > + * in the Software without restriction, including without limitation > > the rights > > > + * to use, copy, modify, merge, publish, distribute, sublicense, and/or > > sell > > > + * copies of the Software, and to permit persons to whom the Software is > > > + * furnished to do so, subject to the following conditions: > > > + * > > > + * The above copyright notice and this permission notice shall be > > included in > > > + * all copies or substantial portions of the Software. > > > + * > > > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, > > EXPRESS OR > > > + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF > > MERCHANTABILITY, > > > + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT > > SHALL > > > + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR > > OTHER > > > + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, > > ARISING FROM, > > > + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER > > DEALINGS IN > > > + * THE SOFTWARE. > > > + */ > > > > Could we use /* SPDX-License-Identifier: GPL-2.0-or-later */ directly ? > > > > [snip] > > > > I guess we could. Probably for a future cleanup though.
checkpatch will complain about this - all newly introduced files should be using SPDX-License-Identifier from the start, with no boilerplate text present. Also it will warn about any license use which is not GPL-2.0-or-later, requesting that it be explained in the commit message. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
