On 8/29/25 04:03, Daniel P. Berrangé wrote:
+enum QMessageContextFlags {
+ QMESSAGE_CONTEXT_SKIP_MONITOR = (1 << 0),
+};
+
+/*
+ * qmessage_context:
+ * @flags: the message formatting control flags
+ *
+ * Format a message prefix with the information
+ * previously selected by a call to
+ * qmessage_set_format.
+ *
+ * If @flags contains QMESSAGE_CONTEXT_SKIP_MONITOR
+ * an empty string will be returned if running in
+ * the context of a HMP command
+ *
+ * Returns: a formatted message prefix, or empty string;
+ * to be freed by the caller.
+ */
+char *qmessage_context(int flags);
I don't like QMESSAGE_CONTEXT_SKIP_MONITOR.
It's just as easy to check monitor_cur in the single user and not call
qmessage_context.
The comment is out-of-date, since you can now return NULL.
That said, I have a follow-up suggestion.
r~
