Hi Tom, On Fri, Sep 12, 2025 at 08:39:09AM -0500, Tom Lendacky wrote: > On 9/11/25 06:54, Naveen N Rao (AMD) wrote: > > Currently, check_sev_features() is called in multiple places when > > processing IGVM files: both when processing the initial VMSA SEV > > features from IGVM, as well as when validating the full contents of the > > VMSA. Move this to a single point in sev_common_kvm_init() to simplify > > the flow, as well as to re-use this function when VMSA SEV features are > > being set without using IGVM files. > > > > Since check_sev_features() relies on SVM_SEV_FEAT_SNP_ACTIVE being set > > in VMSA SEV features depending on the guest type, set this flag by > > default when creating SEV-SNP guests. When using IGVM files, this field > > is anyway over-written so that validation in check_sev_features() is > > still relevant. > > There seem to be multiple things going on in this patch and I wonder if it > would be best to split it up into separate smaller patches. > > You have setting of SVM_SEV_FEAT_SNP_ACTIVE in sev_features, you have a > new check for sev_features being set when using an IGVM file and you have > the consolidation.
Sure, I started with the premise of unifying the call to check_sev_features() which necessitated the other changes. I will move those as pre-req patches. Thanks for the review, - Naveen
