On 9/18/25 05:27, Naveen N Rao (AMD) wrote:
> Now that users can enable VMSA SEV features, update sev_init2_required()
> to return true if any SEV features are requested. This enables qemu to
> use KVM_SEV_INIT2 for SEV-ES guests when necessary.
>
> Sample command-line:
> -machine q35,confidential-guest-support=sev0 \
> -object
> sev-guest,id=sev0,policy=0x5,cbitpos=51,reduced-phys-bits=1,debug-swap=on
>
Should this patch go before patch #5 from a bisect point of view? Because
won't patch #5 fail because you still aren't using init2?
> Reviewed-by: Nikunj A Dadhania <nik...@amd.com>
> Signed-off-by: Naveen N Rao (AMD) <nav...@kernel.org>
Reviewed-by: Tom Lendacky <thomas.lenda...@amd.com>
> ---
> target/i386/sev.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/target/i386/sev.c b/target/i386/sev.c
> index 4f1b0bf6ccc8..6b11359f06dd 100644
> --- a/target/i386/sev.c
> +++ b/target/i386/sev.c
> @@ -1704,8 +1704,7 @@ sev_vm_state_change(void *opaque, bool running,
> RunState state)
> */
> static bool sev_init2_required(SevGuestState *sev_guest)
> {
> - /* Currently no KVM_SEV_INIT2-specific options are exposed via QEMU */
> - return false;
> + return !!SEV_COMMON(sev_guest)->sev_features;
> }
>
> static int sev_kvm_type(X86ConfidentialGuest *cg)
