Re: [PATCH v4 16/23] util: fix interleaving of error & trace output

[Richard Henderson]

On 9/25/25 02:44, Daniel P. Berrangé wrote:

+    if (monitor_cur_is_hmp()) {
+        cur = monitor_cur();
+    }

Didn't your last patch set return Montor* from monitor_cur_is_hmp?
Because this takes the locks in monitor_cur() twice.

+    if (message_with_timestamp && !cur) {
         timestr = real_time_iso8601();
-        error_printf("%s ", timestr);
+        error_printf_mon(NULL, "%s ", timestr);

Passing NULL to error_printf_mon is fprintf to stderr.


r~