Hi Akihiko, > Subject: Re: [PATCH v1 2/7] virtio-gpu: Don't rely on res->blob to identify > blob > resources > > On 2025/10/04 8:35, Vivek Kasireddy wrote: > > The res->blob pointer may not be valid (non-NULL) for some blobs > > where the backing storage is not memfd based. Therefore, we cannot > > use it to determine if a resource is a blob or not. Instead, we > > could use res->blob_size to make this determination as it is > > non-zero for blob resources regardless of where their backing > > storage is located. > > I think this patch is no longer necessary since now you add code to > mmap() VFIO storage with "[PATCH v1 7/7] virtio-gpu-udmabuf: Create > dmabuf for blobs associated with VFIO devices". Right, but given that mmap() can still fail for various reasons and this use-case can work as long as dmabuf creation succeeds, I think it makes sense to not rely on res->blob to determine if a resource is blob or not.
Thanks, Vivek
