On 10/10/25 16:37, Philippe Mathieu-Daudé wrote:
On 10/10/25 15:51, Paolo Bonzini wrote:
On 10/10/25 15:42, Philippe Mathieu-Daudé wrote:
Replace compile-time #ifdef with a runtime check to ensure all code
paths are built and tested. This reduces build-time configuration
complexity and improves maintainability.
No functional change intended.
No need to repost (and I didn't review), but please change throughout
the commit message to mention a *compile-time* if() check. The code
for the wrong endianness will not make it past compilation, and
mentioning runtime checks left me wondering if you had mistaken HOST
for TARGET.
I want HOST, and hope the changes are correct: I meant to express the
code is elided by the compiler, indeed not at *runtime* 🤦 I'll reword
the commit description. Thanks for catching this.
What about:
Replace preprocessor-time #ifdef with a compile-time check
to ensure all code paths are built and tested. This reduces
build-time configuration complexity and simplifies code
maintainability.
?
